2020-04-13 16:44:42 +00:00
|
|
|
function(add_clazy_check target)
|
2020-04-18 16:36:28 +00:00
|
|
|
find_program(CLAZY_EXE NAMES clazy-standalone)
|
2019-06-15 13:16:27 +00:00
|
|
|
set(_sources ${ARGN})
|
2020-04-18 16:36:28 +00:00
|
|
|
set(_clazy_checks
|
2020-04-18 16:40:13 +00:00
|
|
|
"container-inside-loop,heap-allocated-small-trivial-type,inefficient-qlist,isempty-vs-count,qt-keywords,unneeded-cast"
|
|
|
|
)
|
2020-04-18 18:56:16 +00:00
|
|
|
set(_args -checks=level2,${_clazy_checks} -extra-arg="-Wno-unknown-warning-option" -export-fixes=clazy-fixes-file.yaml)
|
2019-06-15 13:16:27 +00:00
|
|
|
|
|
|
|
if(CLAZY_EXE)
|
2019-06-27 02:18:29 +00:00
|
|
|
if(NOT TARGET clazy-check)
|
|
|
|
add_custom_target(clazy-check)
|
|
|
|
endif()
|
2020-04-18 16:40:13 +00:00
|
|
|
add_custom_target(clazy-check-${target} WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
|
|
|
COMMAND ${CLAZY_EXE} ${_args} -p ${CMAKE_BINARY_DIR} ${_sources})
|
2020-04-13 16:44:42 +00:00
|
|
|
add_dependencies(clazy-check-${target} ${target})
|
|
|
|
add_dependencies(clazy-check clazy-check-${target})
|
2020-04-18 18:56:16 +00:00
|
|
|
|
2020-04-18 20:31:40 +00:00
|
|
|
option(CMLIB_CLAZY_FIX_QT_KEYWORDS "Fix Qt keywords" OFF)
|
|
|
|
option(CMLIB_CLAZY_FIX_RANGE_LOOP_ADD_REF "Fix range loop add reference" OFF)
|
|
|
|
option(CMLIB_CLAZY_FIX_RANGE_LOOP_ADD_QASCONST "Fix range loop add qAsConst" OFF)
|
|
|
|
option(CMLIB_CLAZY_FIX_FUNCTION_ARGS_BY_REF "Fix function args by reference" OFF)
|
|
|
|
option(CMLIB_CLAZY_FIX_OLD_STYLE_CONNECT "Fix old style connect" OFF)
|
|
|
|
option(CMLIB_CLAZY_FIX_STRING_ALLOCATIONS "Fix string allocations" OFF)
|
2020-04-18 18:56:16 +00:00
|
|
|
|
2020-04-18 20:31:40 +00:00
|
|
|
if(CMLIB_CLAZY_FIX_QT_KEYWORDS OR
|
|
|
|
CMLIB_CLAZY_FIX_RANGE_LOOP_ADD_REF OR
|
|
|
|
CMLIB_CLAZY_FIX_RANGE_LOOP_ADD_QASCONST OR
|
|
|
|
CMLIB_CLAZY_FIX_FUNCTION_ARGS_BY_REF OR
|
|
|
|
CMLIB_CLAZY_FIX_OLD_STYLE_CONNECT OR
|
|
|
|
CMLIB_CLAZY_FIX_STRING_ALLOCATIONS)
|
2020-04-18 18:56:16 +00:00
|
|
|
if(NOT TARGET clazy-fix)
|
|
|
|
add_custom_target(clazy-fix)
|
|
|
|
endif()
|
2020-04-18 20:31:40 +00:00
|
|
|
if(CMLIB_CLAZY_FIX_QT_KEYWORDS)
|
|
|
|
add_custom_target(clazy-fix-qt-keywords-${target} WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
|
|
|
COMMAND ${CMAKE_COMMAND} -E env "CLAZY_FIXIT=fix-qt-keywords"
|
2020-04-18 18:56:16 +00:00
|
|
|
${CLAZY_EXE} ${_args} -p ${CMAKE_BINARY_DIR} ${_sources})
|
2020-04-18 20:31:40 +00:00
|
|
|
add_dependencies(clazy-fix-qt-keywords-${target} ${target})
|
|
|
|
add_dependencies(clazy-fix clazy-fix-qt-keywords-${target})
|
|
|
|
endif()
|
|
|
|
if(CMLIB_CLAZY_FIX_RANGE_LOOP_ADD_REF)
|
|
|
|
add_custom_target(clazy-fix-range-loop-add-ref-${target} WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
|
|
|
COMMAND ${CMAKE_COMMAND} -E env "CLAZY_FIXIT=fix-range-loop-add-ref"
|
|
|
|
${CLAZY_EXE} ${_args} -p ${CMAKE_BINARY_DIR} ${_sources})
|
|
|
|
add_dependencies(clazy-fix-range-loop-add-ref-${target} ${target})
|
|
|
|
add_dependencies(clazy-fix clazy-fix-range-loop-add-ref-${target})
|
|
|
|
endif()
|
|
|
|
if(CMLIB_CLAZY_FIX_RANGE_LOOP_ADD_QASCONST)
|
|
|
|
add_custom_target(clazy-fix-range-loop-add-qasconst-${target} WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
|
|
|
COMMAND ${CMAKE_COMMAND} -E env "CLAZY_FIXIT=fix-range-loop-add-qasconst"
|
|
|
|
${CLAZY_EXE} ${_args} -p ${CMAKE_BINARY_DIR} ${_sources})
|
|
|
|
add_dependencies(clazy-fix-range-loop-add-qasconst-${target} ${target})
|
|
|
|
add_dependencies(clazy-fix clazy-fix-range-loop-add-qasconst-${target})
|
|
|
|
endif()
|
|
|
|
if(CMLIB_CLAZY_FIX_FUNCTION_ARGS_BY_REF)
|
|
|
|
add_custom_target(clazy-fix-function-args-by-ref-${target} WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
|
|
|
COMMAND ${CMAKE_COMMAND} -E env "CLAZY_FIXIT=fix-function-args-by-ref"
|
|
|
|
${CLAZY_EXE} ${_args} -p ${CMAKE_BINARY_DIR} ${_sources})
|
|
|
|
add_dependencies(clazy-fix-function-args-by-ref-${target} ${target})
|
|
|
|
add_dependencies(clazy-fix clazy-fix-function-args-by-ref-${target})
|
2020-04-18 18:56:16 +00:00
|
|
|
endif()
|
|
|
|
if(CMLIB_CLAZY_FIX_OLD_STYLE_CONNECT)
|
|
|
|
add_custom_target(clazy-fix-old-style-connect-${target} WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
|
|
|
COMMAND ${CMAKE_COMMAND} -E env "CLAZY_FIXIT=fix-old-style-connect"
|
|
|
|
${CLAZY_EXE} ${_args} -p ${CMAKE_BINARY_DIR} ${_sources})
|
|
|
|
add_dependencies(clazy-fix-old-style-connect-${target} ${target})
|
|
|
|
add_dependencies(clazy-fix clazy-fix-old-style-connect-${target})
|
|
|
|
endif()
|
2020-04-18 20:31:40 +00:00
|
|
|
# "fix-qlatin1string-allocations", "qstring-allocations");
|
|
|
|
# "fix-fromLatin1_fromUtf8-allocations", "qstring-allocations");
|
|
|
|
# "fix-fromCharPtrAllocations", "qstring-allocations");
|
|
|
|
if(CMLIB_CLAZY_FIX_STRING_ALLOCATIONS)
|
|
|
|
add_custom_target(clazy-fix-string-${target} WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
|
|
|
COMMAND ${CMAKE_COMMAND} -E env "CLAZY_FIXIT=fix-qlatin1string-allocations"
|
|
|
|
${CLAZY_EXE} ${_args} -p ${CMAKE_BINARY_DIR} ${_sources})
|
|
|
|
add_dependencies(clazy-fix-string-${target} ${target})
|
|
|
|
add_dependencies(clazy-fix clazy-fix-string-${target})
|
|
|
|
endif()
|
2020-04-18 18:56:16 +00:00
|
|
|
endif()
|
2019-06-15 13:16:27 +00:00
|
|
|
else()
|
2019-08-10 07:30:01 +00:00
|
|
|
message(STATUS "CMLIB warning:")
|
2020-04-18 16:36:28 +00:00
|
|
|
message(STATUS " Clazy standalone analyzer is not found")
|
2019-06-15 13:16:27 +00:00
|
|
|
endif()
|
|
|
|
endfunction()
|